feat: namespace EC2 tags #3523
Merged
feat: namespace EC2 tags #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaNavdeep1983
previously approved these changes
Oct 3, 2023
GuptaNavdeep1983
approved these changes
Oct 4, 2023
npalm
pushed a commit
that referenced
this pull request
Oct 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.1...v4.5.0) (2023-10-04) ### Features * namespace EC2 tags ([#3523](#3523)) ([35aa73a](35aa73a)) ### Bug Fixes * **lambda:** Bump @aws-lambda-powertools/logger from 1.12.1 to 1.14.0 in /lambdas ([#3521](#3521)) ([3f42529](3f42529)) * **lambda:** Bump the aws group in /lambdas with 5 updates ([#3525](#3525)) ([1b24342](1b24342)) * **lambda:** Bump the octokit group in /lambdas with 1 update ([#3519](#3519)) ([cde80cd](cde80cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The runners are still using a some ec2 tags such as Type, Repo, Owner for selecting runners controlled by the control plane. Since the tags are not namespaced they can conflict existing tags used in an AWS account. This PR is namespacing the tags like the other tags used by the module with
ghr.Verification