Draft: First try at parsing the timezone information for the sony A7 camera

[fwsmit]

I'm working on creating a PR to fix #187. I've never used typescript before, so I need some help. How can I run the tests in this repository? I could not find documentation about that.

I know that there should be some more code to only do this for some Sony camera's, but first I wanted to check if this works. What would be a reasonable include-list? Only my model of Sony camera (ICLE-7)?

[mceachen]

How can I run the tests in this repository?

yarn test

(you may need to install a recent version of Node.js and run npm i -g yarn).

What would be a reasonable include-list?

It might be safe enough to put this at the very bottom of the timezone inference heuristics -- we'd certainly prefer something like GPS or an explicit TimezoneOffset over this wholly-undocumented, might-be-in-UTC-but-who-knows sony-specific tag.

Also: the tag name will be CamelCased (like all others). Use exiftool -j -struct $file to see what this library is seeing (ish).

[fwsmit]

How can I run the tests in this repository?

yarn test

(you may need to install a recent version of Node.js and run npm i -g yarn).

Thank you. I also needed to do a yarn install or npm install and install perl. It would be nice if there was some documenation for how to setup a developer environment.

What would be a reasonable include-list?

It might be safe enough to put this at the very bottom of the timezone inference heuristics -- we'd certainly prefer something like GPS or an explicit TimezoneOffset over this wholly-undocumented, might-be-in-UTC-but-who-knows sony-specific tag.

Also: the tag name will be CamelCased (like all others). Use exiftool -j -struct $file to see what this library is seeing (ish).

I made the name camel cased and added it to the end of the list. Now all tests pass. I don't know what a reasonable test would be to add here, since I'm just adding another name of a UTC tag. Would it be possible to test this on an actual image from my camera?

[fwsmit]

Hi, any chance you could take a look at this PR?

[mceachen]

Unfortunately this file is automatically generated, and this diff (which is required for the other diff to compile) will get reverted.

There's a list of "required" tags in mktags.ts that needs this new tag name added to.

[fwsmit]

Okay, I added it to the mktags.ts file. I also removed it from src/Tags.ts, since it should be automatically generated. To rerun the generation, I saw that you need to run yarn run mktags *picture_dir*. Only I don't see which directory of pictures is used to generate the current list.

[mceachen]

LGTM. I'll write some tests.

[fwsmit]

Thanks!

[mceachen]

The failed GitHub Actions tests were a doozy to fix. I documented it here: https://photostructure.com/coding/node-22-exit-handler-never-called/