New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bogus tree setting code from parentnode/tree.c #15044

Merged

nielsdos merged 1 commit into php:master from nielsdos:parentnode-tree-settree

Jul 21, 2024

Commits on Jul 20, 2024

Remove bogus tree setting code from parentnode/tree.c

I don't know why this code was here in the first place, it is present
since the initial implementation. It doesn't make sense because:
1. It would require updating the refcounts if the document wasn't
   actually already set.
2. We enforce that the document is the same as the target document by
   this point, so setting the tree is pointless.

nielsdos committed Jul 20, 2024