Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Ignored tag of locale #154

Merged
merged 8 commits into from
Dec 29, 2021
Merged

[Bugfix] Ignored tag of locale #154

merged 8 commits into from
Dec 29, 2021

Conversation

GMetaxakis
Copy link
Contributor

After the merge of the #143 a bug was introduced to the system that if we were using the cli with tag param, it was ignoring the tag that was passed to the locale file.

@GMetaxakis
Copy link
Contributor Author

@egze and @theSoenke that you were very nice of accepting and merging the #143 if you have time take a look on the bugfix of my bug ... :P :D

Copy link
Collaborator

@theSoenke theSoenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GMetaxakis Thank you for providing the fix. Looks good ✔️

@theSoenke theSoenke merged commit 3e630b6 into phrase:master Dec 29, 2021
@theSoenke
Copy link
Collaborator

The change is now released in v2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants