feat(API): Implement figma attachments endpoints #415
Conversation
Varpuspaavi
commented
Sep 27, 2023
•
Varpuspaavi
commented
- https://phrase.atlassian.net/browse/TSE-613
- https://github.com/phrase/phrase/pull/11856
Varpuspaavi
changed the title
|
Reminder to self: I will bump GO before Bumping the CLI |
| --- | ||
| summary: Attach the Figma attachment to a key | ||
| description: Attach the Figma attachment to a key | ||
| operationId: figma_attachment_key/create |
There was a problem hiding this comment.
wouldn't it be more logical to add these operations to figma_attachments (or perhaps keys) instead?
There was a problem hiding this comment.
Adjusted, not exactly sure if this is what you meant
CR
There was a problem hiding this comment.
yeah, but they'd also have to live on paths/figma_attachments IMO
There was a problem hiding this comment.
but I guess the API PR has already been merged in phrase?
There was a problem hiding this comment.
Yes the API PR is merged. Can we have two create.yaml/destroy.yaml in the same folder? I could adjust this. On the API PR we agreed to not use custom named methods and instead went with second controller to have option for second create/destroy paths
