-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: add missing required params #571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSoenke
force-pushed
the
add-required-params
branch
from
April 16, 2024 12:39
2806ceb
to
b8a4e2a
Compare
theSoenke
changed the title
Add missing required params
BREAKING CHANGE: Add missing required params
Apr 16, 2024
theSoenke
force-pushed
the
add-required-params
branch
from
April 16, 2024 12:41
b8a4e2a
to
abe3926
Compare
theSoenke
changed the title
BREAKING CHANGE: Add missing required params
feat: add missing required params
Apr 16, 2024
theSoenke
force-pushed
the
add-required-params
branch
8 times, most recently
from
April 19, 2024 09:07
1ee4b80
to
dfd983c
Compare
theSoenke
changed the title
feat: add missing required params
breaking change!: add missing required params
Apr 19, 2024
theSoenke
changed the title
breaking change!: add missing required params
refactor!: add missing required params
Apr 19, 2024
theSoenke
force-pushed
the
add-required-params
branch
2 times, most recently
from
April 19, 2024 09:14
cdb0251
to
359db28
Compare
jablan
reviewed
Apr 19, 2024
jablan
reviewed
Apr 19, 2024
theSoenke
force-pushed
the
add-required-params
branch
4 times, most recently
from
April 22, 2024 07:19
b4db842
to
622eadc
Compare
hahmed-dev
reviewed
Apr 22, 2024
theSoenke
force-pushed
the
add-required-params
branch
from
April 22, 2024 08:55
1ae4402
to
78d18ad
Compare
theSoenke
force-pushed
the
add-required-params
branch
from
April 22, 2024 11:18
b1d3aa6
to
2010960
Compare
hahmed-dev
reviewed
Apr 22, 2024
hahmed-dev
reviewed
Apr 22, 2024
jablan
reviewed
Apr 22, 2024
hahmed-dev
reviewed
Apr 22, 2024
theSoenke
force-pushed
the
add-required-params
branch
from
April 22, 2024 13:43
32e7441
to
a8a313e
Compare
hahmed-dev
approved these changes
Apr 22, 2024
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve documentation of required params. This will be a breaking change for some endpoints in the libraries and will be released in a new major version. It's not a breaking change for the REST API itself as these param were already required before and returned a 422 in case they were missing
The following endpoints now have additional required parameters:
authorizations#create
-note
is requiredblacklisted_keys#create
-name
is requiredbranches#create
-name
is requireddistributions#create
-name
,project_id
are requiredfigma_attachements#create
-url
is requiredglossaries#create
-name
is requiredglossary_term_translations#create
-locale_code
,content
are requiredglossary_terms#create
-term
is requiredinvitations#create
-email
,role
are requiredjobs#create
-name
is requiredkeys#create
-name
is requiredlocales#create
-name
,code
are requiredorders#create
-name
,lsp
are requiredprojects#create
-name
is requiredscreenshot_markers#create
-key_id
is requiredspaces#create
-name
is requiredstyleguides#create
-title
is requiredtags#create
-name
is requiredteams#add_project
-id
is requiredteam#add_space
-id
is requiredteams#add_user
-id
is requiredteams#create
-name
is requiredtranslations#create
-locale_id
,key_id
are requireduploads#create
-file
,file_format
,locale_id
are requiredvariables#create
-name
is requiredwebhooks#create
-callback_url
is required