[Task]: Remove system/admin settings remnants #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvesh3
reviewed
Apr 21, 2023
mattamon
requested changes
Apr 21, 2023
There was a problem hiding this comment.
Do we need all parts of the helper.
The default keybindings should be defined in the config itself -> https://github.com/pimcore/admin-ui-classic-bundle/blob/1.x/config/pimcore/default.yaml#L22 So we could remove the legacy ones.
And the strict method is also not needed anymore since all values have now the default false unless set to true.
Check the Configuration.php -> https://github.com/pimcore/admin-ui-classic-bundle/blob/1.x/src/DependencyInjection/Configuration.php#L463
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves pimcore/pimcore#14997