Bugfix: support drag & drop for custom field types

[BlackbitDevs]

In

admin-ui-classic-bundle/public/js/pimcore/helpers.js

Line 3382 in 7554a0f

const allowedChildren = pimcore.object.helpers.layout.getRawAllowedTypes();

method getRawAllowedTypes() gets used. This only returns Pimcore's built-in field types, see

admin-ui-classic-bundle/public/js/pimcore/object/helpers/layout.js

Lines 26 to 40 in 7554a0f

	getRawAllowedTypes : function () {
	return {
	accordion: ["panel", "region", "tabpanel", "text", "iframe"],
	fieldset: ["data", "text", "iframe"],
	fieldcontainer: ["data", "text", "iframe"],
	panel: ["data", "region", "tabpanel", "button", "accordion", "fieldset", "fieldcontainer", "panel", "text", "html", "iframe"],
	region: ["panel", "accordion", "tabpanel", "text", "localizedfields", "iframe"],
	tabpanel: ["panel", "region", "accordion", "text", "localizedfields", "iframe", "tabpabel"],
	button: [],
	text: [],
	root: ["panel", "region", "tabpanel", "accordion", "text", "iframe", "button", "fieldcontainer", "fieldset"],
	localizedfields: ["data", "panel", "tabpanel", "accordion", "fieldset", "fieldcontainer", "text", "region", "button", "iframe"],
	block: ["data", "panel", "tabpanel", "accordion", "fieldset", "fieldcontainer", "text", "region", "button", "iframe"]
	};
	},

But if the application adds custom field types via prepareClassLayoutContextMenu event, the custom field type will be addable because in

admin-ui-classic-bundle/public/js/pimcore/object/classes/class.js

Line 356 in 7554a0f

var allowedTypes = pimcore.object.helpers.layout.getAllowedTypes(this);

getAllowedTypes() gets used but it is not possible to drag & drop custom fields because

admin-ui-classic-bundle/public/js/pimcore/helpers.js

Lines 3379 to 3392 in 7554a0f

	pimcore.helpers.isComponentAsChildAllowed = function (parentNode, childNode) {
	const parentType = parentNode.data.editor.type;
	const childType = childNode.data.editor.type;
	const allowedChildren = pimcore.object.helpers.layout.getRawAllowedTypes();
	if (allowedChildren[parentType] &&
	allowedChildren[parentType].includes(childType) ||
	(allowedChildren[parentType].includes('data') && childNode.data.type === 'data')
	) {
	return true
	}
	return false;
	}

returns false when dropping the custom field.

[sonarcloud]

Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[robertSt7]

@BlackbitDevs Thanks a lot for the fix