This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
restore: auto remove/add pd scheduler in restore #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
force-pushed
the
pd_scheduler
branch
from
96cdc05
to
fb1ed17
Compare
|
/run-all-tests |
4 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 33 33
Lines 3483 3483
=======================================
Hits 2571 2571
Misses 589 589
Partials 323 323Continue to review full report at Codecov.
|
kennytm
reviewed
Dec 20, 2019
| } | ||
| ctx, cancel := context.WithCancel(GetDefaultContext()) | ||
| defer cancel() | ||
| func runRestore(flagSet *flag.FlagSet, cmdName, dbName, tableName string) error { |
Sure, I think we should check is online in prepareWork |
kennytm
reviewed
Dec 20, 2019
kennytm
reviewed
Dec 23, 2019
| } | ||
|
|
||
| func addPDLeaderScheduler(ctx context.Context, mgr *conn.Mgr, removedSchedulers []string) error { | ||
| for _, scheduler := range removedSchedulers { |
There was a problem hiding this comment.
Question. Since map is randomly ordered, the schedulers are added in random order as well. Is this OK for PD?
There was a problem hiding this comment.
AFAIK, yes, there is no dependency problem between each scheduler.
overvenus
pushed a commit
to overvenus/br-1
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.