Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Release 4.0 merge master #200

Merged
merged 31 commits into from
Mar 20, 2020
Merged

Release 4.0 merge master #200

merged 31 commits into from
Mar 20, 2020

Commits on Jan 22, 2020

  1. restore: merge tidb-tools/pkg/restore-util (pingcap#146) 

    * restore-util: Implement split/scatter (pingcap#274)

* implement split/scatter

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* init test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* redesign output/input of the lib

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* update dependency

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add commments and more tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add ScanRegions interface to Client

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix potential data race

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: kennytm <kennytm@gmail.com>

* Update pkg/restore-util/client.go

Co-Authored-By: kennytm <kennytm@gmail.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* update dependency

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* resolve conflicts

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix prefix rewrite

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add RewriteRule/skip failed scatter region/retry the SplitRegion

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* check if region has peer

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* more logs

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: add split retry interval (pingcap#277)

* reset dependencies to release-3.1

* add split retry interval

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix go.sum

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: wait for scatter region sequentially  (pingcap#279)

* wait for scatter region sequentially

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: add on split hook (pingcap#281)

* restore-util: add on split hook

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Nil check onSplit

Co-Authored-By: kennytm <kennytm@gmail.com>

* restore-util: fix returned new region is nil (pingcap#283)

* restore-util: fix returned new region is nil

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* more logs

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* *: gofmt

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: kennytm <kennytm@gmail.com>

* fix log

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: call onSplit on splitByRewriteRules (pingcap#285)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore-util: fix overlapped error message (pingcap#293)

* restore-util: fix overlapped error message

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix log message

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* reduce error trace

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: log warning when cannot find matched rewrite rule (pingcap#299)

* restore-util: add method to set placement rules and store labels (pingcap#301)

* restore-util: add method to set placement rules and store labels

Signed-off-by: disksing <i@disksing.com>

* minor fix

Signed-off-by: disksing <i@disksing.com>

* address comment

Signed-off-by: disksing <i@disksing.com>

* add GetPlacementRules

Signed-off-by: disksing <i@disksing.com>

* fix test

Signed-off-by: disksing <i@disksing.com>

* restore-util: support batch split (pingcap#300)

* restore-util: support batch split

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* go fmt

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: kennytm <kennytm@gmail.com>

* address commits

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Update pkg/restore-util/split.go

Co-Authored-By: kennytm <kennytm@gmail.com>

* add onSplit callback

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: add upper bound time for waiting for scatter (pingcap#305)

* restore: fix scatter regions failed

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add log

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* stop waiting for scatter after 3min

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* restore-util: fix wrong url (pingcap#306)

Signed-off-by: disksing <i@disksing.com>

* restore-util: add warning about unmatched table id (pingcap#313)

* restore-util: support table partition

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix log

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* warn table id does not match

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add unit tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: Neil Shen <overvenus@gmail.com>

* fix compile error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

Co-authored-by: Ian <ArGregoryIan@gmail.com>
Co-authored-by: Neil Shen <overvenus@gmail.com>

* *: prune tidb-tools

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore: address linters suggestions

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore: merge restoreutil into restore

Signed-off-by: Neil Shen <overvenus@gmail.com>

* address comment

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: 5kbpers <20279863+5kbpers@users.noreply.github.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: disksing <i@disksing.com>
Co-authored-by: Ian <ArGregoryIan@gmail.com>
    @overvenus @5kbpers
    @kennytm @disksing @IANTHEREAL
    5 people committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    0a43d2a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Fixed handling for a dbName that do not exist in the backup being res… 

    …tored (pingcap#148)

* Fixed handling for a dbName that do not exist in the backup being restored

* Fixed handling for a dbName that do not exist in the backup being restored
    Kolbe Kegel authored Feb 1, 2020
    Configuration menu
    Copy the full SHA
    3863a3a View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. validate: fix debug meta test ci (pingcap#153) 

    * validate: fix debug meta test ci
    @3pointer
    3pointer authored Feb 5, 2020
    Configuration menu
    Copy the full SHA
    6b65080 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. *: extracts runBackup/runRestore in cmd into pkg/task (pingcap#156) 

    * *: extracts runBackup/runRestore in cmd into pkg/task

Defines a "Config" structure to store the parsed flags.

Use the "black-white-list" structure to define what tables/databases to
backup/restore.

* go.mod: update tidb to v4.0.0-beta
    @kennytm
    kennytm authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    0dfe82d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. restore: fix restore summary log (pingcap#150) 

    Co-authored-by: kennytm <kennytm@gmail.com>
    @3pointer @kennytm
    3pointer and kennytm authored Feb 13, 2020
    Configuration menu
    Copy the full SHA
    8c97452 View commit details
    Browse the repository at this point in the history

  2. restore: enhance error handling (pingcap#152) 

    * restore: enhance error handling

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* unit test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix region epoch error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* remove `Restore*`

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address lint

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add debug log

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Apply suggestions from code review

Co-Authored-By: kennytm <kennytm@gmail.com>

* Update pkg/restore/import.go

Co-Authored-By: kennytm <kennytm@gmail.com>

* fix retry error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* handle RegionNotFound error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
    @5kbpers @overvenus @kennytm
    3 people authored Feb 13, 2020
    Configuration menu
    Copy the full SHA
    008ec45 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Incremental BR: support DDL (pingcap#155) 

    * support backup&restore ddl

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* integration tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* update kvproto

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix integration tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* reduce cyclomatic complexity of `runRestore`

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* add unit test

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix tests

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* disable fast checksum in incremental br

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix no valid key error

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address lint

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
    @5kbpers
    5kbpers authored Feb 20, 2020
    Configuration menu
    Copy the full SHA
    1e1fc97 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. Reduce TiDB dependencies (pingcap#158) 

    * utils: exclude mock_cluster outside of unit test

* utils: remove unused ResultSetToStringSlice()

* *: abstract away dependencies of tidb/session into a Glue interface

* *: fix hound lint

* util,mock: move utils.MockCluster to mock.Cluster

* restore: fix test build failure

Co-authored-by: 3pointer <qdlc2010@gmail.com>
    @kennytm @3pointer
    kennytm and 3pointer authored Feb 22, 2020
    Configuration menu
    Copy the full SHA
    4492b8f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. go.mod: update tidb (pingcap#168) 

    Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Feb 23, 2020
    Configuration menu
    Copy the full SHA
    3c9d42f View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. BR support TLS (pingcap#161) 

    * *: support tls

* move tikv.driver to glue

* fix comments
    @3pointer
    3pointer authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    028963d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. upgrade golangci and prepare for go 1.14 (pingcap#171) 

    Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Feb 28, 2020
    Configuration menu
    Copy the full SHA
    e462f80 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. backup: add raw backup command (pingcap#101) 

    * backup: add raw backup command
    @3pointer
    3pointer authored Mar 4, 2020
    Configuration menu
    Copy the full SHA
    4657932 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. restore: speed up retry on not leader (pingcap#179) 

    * tests: stable cluster start up

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tests: fix unbound var

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore: speed retry on not leader

Signed-off-by: Neil Shen <overvenus@gmail.com>

* address comments

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tests: add --cacert flag

Signed-off-by: Neil Shen <overvenus@gmail.com>

* make codecov green

Signed-off-by: Neil Shen <overvenus@gmail.com>

* address comments

Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0a1a044 View commit details
    Browse the repository at this point in the history

  2. conn, restore: paginate scan regions (pingcap#165) 

    * conn, restore: paginate scan regions

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tests: large timeout

Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Mar 5, 2020
    Configuration menu
    Copy the full SHA
    09fb715 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Batch restore (pingcap#167) 

    * *: unify Range and RangeTree

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore: split restore files into small batch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* task: set default restore concurrency to 128

Signed-off-by: Neil Shen <overvenus@gmail.com>

* restore: unused table worker pool

Signed-off-by: Neil Shen <overvenus@gmail.com>

* summary: sum up repeated duration and int

Signed-off-by: Neil Shen <overvenus@gmail.com>

* rtree: move rtree from utils to pkg

Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    82b5016 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. README, docker: add quick start (pingcap#181) 

    * README, docker: add quick start

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cmd: disable some TiDB log

Signed-off-by: Neil Shen <overvenus@gmail.com>

* docker: build go-ycsb automatically

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cmd: add TODO about TiDB logs

Signed-off-by: Neil Shen <overvenus@gmail.com>
    @overvenus
    overvenus authored Mar 7, 2020
    Configuration menu
    Copy the full SHA
    3fc9ee2 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. *: update tidb dependency build with go1.14 (pingcap#176)

    @3pointer
    3pointer authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    237fe5b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. *: add license header (pingcap#182) 

    * rtree: move checkFile into backup

Signed-off-by: Neil Shen <overvenus@gmail.com>

* *: add license header

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Update LICENSE.md

Co-Authored-By: kennytm <kennytm@gmail.com>

Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>
    @overvenus @kennytm @3pointer
    3 people authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0672ab3 View commit details
    Browse the repository at this point in the history

  2. conn: support not shutting down the storage when closing the connecti… 

    …on (pingcap#185)

Co-authored-by: 3pointer <luancheng@pingcap.com>
    @kennytm @3pointer
    kennytm and 3pointer authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9caa6de View commit details
    Browse the repository at this point in the history

  3. conn: use GetDomain to avoid some TiDB breaking changes (pingcap#186) 

    * conn: use GetDomain to avoid some TiDB breaking changes

Signed-off-by: Neil Shen <overvenus@gmail.com>

* minor usability improvement

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: kennytm <kennytm@gmail.com>
    @overvenus @kennytm
    overvenus and kennytm authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7d59284 View commit details
    Browse the repository at this point in the history

  4. fix check safepoint & unhide experimental features (pingcap#175) 

    * backup: check safepoint for last backup ts

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* check lastbackupts > 0

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* unhide experimental features

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comment

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Update tests/br_z_gc_safepoint/run.sh

Co-Authored-By: kennytm <kennytm@gmail.com>

Co-authored-by: kennytm <kennytm@gmail.com>
    @5kbpers @kennytm
    5kbpers and kennytm authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0e25496 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. support backupts (pingcap#172) 

    * support backupts

* address comment

* address comment

* fix space
    @3pointer
    3pointer authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    3419d8a View commit details
    Browse the repository at this point in the history

  2. *: update pd deps to v4 (pingcap#184) 

    Co-authored-by: 3pointer <luancheng@pingcap.com>
    @kennytm @3pointer
    kennytm and 3pointer authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    e476c82 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. restore: support online restore (pingcap#114) 

    Signed-off-by: disksing <i@disksing.com>
    @disksing
    disksing authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    9c2bf9d View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. metrics: add grafana scripts (pingcap#140) 

    * add grafana scripts

* fix

Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: kennytm <kennytm@gmail.com>
    @WangXiangUSTC @3pointer
    @glorv @kennytm
    4 people authored Mar 15, 2020
    Configuration menu
    Copy the full SHA
    512855d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. filter out all TiFlash nodes when retrieving lists of stores from PD (p… 

    …ingcap#187)

* conn: ignore nodes with label engine=tiflash

* conn: disallow TiFlash on restore, only skip TiFlash on backup
    @kennytm
    kennytm authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    6b88e51 View commit details
    Browse the repository at this point in the history

  2. Create integration test for S3 storage (pingcap#174)

    @kennytm
    kennytm authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    156f003 View commit details
    Browse the repository at this point in the history

  3. Fix summary log (pingcap#191) 

    * *: fix restore summary log after restore logic changed to files

* fix

* fix

* fix

Co-authored-by: kennytm <kennytm@gmail.com>
    @3pointer @kennytm
    3pointer and kennytm authored Mar 16, 2020
    Configuration menu
    Copy the full SHA
    bbedfc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Implement Raw Restore (pingcap#104) 

    * Update kvproto

* Implement raw restore

* fix build

* Set range for file importer

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Remove unnecessary comments

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* check cf and support multi ranges in BackupMeta

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Check files' cf; address comments

* adjust structure to keep consistent with master

* Fix build

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Fix build and make check, avoid accessing TiDB in rawkv mode

* Fix test

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Fix tests

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Fix broken logic after merging master

* Update pkg/task/restore_raw.go

Co-Authored-By: Neil Shen <overvenus@gmail.com>

* Address comments

* Address comments

* Mark raw restore as experimental

* Fix build

* Address comments

* test: Add check for deleting data and partial backup

* Fix build

* Add license header

* fix ci

* fix ci

Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
    @MyonKeminta @3pointer
    @overvenus @sre-bot
    5 people authored Mar 17, 2020
    Configuration menu
    Copy the full SHA
    c3d26d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. restore: remove tiflash replica before restore (pingcap#194) 

    * restore: remove tiflash replica before restore

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* rename errSplit variable

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* check replica count by region info

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* cleanup

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* save tiflash replica count to backupmeta

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix save crcxor

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* fix decode the key of placement rule

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address lint

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* close domain after restoring tiflash-replica

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* address comments

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* Update pkg/task/restore.go

Co-Authored-By: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 3pointer <qdlc2010@gmail.com>
    @5kbpers @3pointer
    5kbpers and 3pointer authored Mar 18, 2020
    Configuration menu
    Copy the full SHA
    6268cde View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. summary: put summary log at last (pingcap#197) 

    * summary: put summary log at last

* fix switch sql
    @3pointer
    3pointer authored Mar 19, 2020
    Configuration menu
    Copy the full SHA
    4ea6c1c View commit details
    Browse the repository at this point in the history