Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: update the eks deployment doc #514

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Conversation

shenli
Copy link
Member

@shenli shenli commented Jun 29, 2020

What is changed, added or deleted? (Required)

Translate #421

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2020

CLA assistant check
All committers have signed the CLA.

@ran-huang ran-huang added needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. labels Jun 29, 2020
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
cp demo.tfvars terraform.tfvars
```

* Deploy a cluster for production environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Deploy a cluster for production environment
* Deploy a cluster for the production environment

en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
@ran-huang ran-huang changed the title eks: Update the eks deployment doc en: update the eks deployment doc Jun 30, 2020
@shenli
Copy link
Member Author

shenli commented Jul 2, 2020

@ran-huang PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 2, 2020
Copy link
Contributor

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@ran-huang,Thanks for your review.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 2, 2020
@ti-srebot
Copy link
Contributor

@DanielZhangQD,Thanks for your review.

en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Jul 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 2, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 580e596 into pingcap:master Jul 2, 2020
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #528

ran-huang pushed a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Shen Li <shenli3514@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants