Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: add doc for global index, also with GLOBAL IndexOption/ColumnOption #18543

Merged
merged 29 commits into from
Aug 19, 2024
Merged

partition: add doc for global index, also with GLOBAL IndexOption/ColumnOption #18543

merged 29 commits into from
Aug 19, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Aug 8, 2024 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Update to #17979 for pingcap/tidb#55264 addition that GLOBAL is explicitly required for Global Indexes, and will also be in the output of SHOW CREATE TABLE. Hopefully it will be included in 8.3

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Defined2014 and others added 14 commits June 20, 2024 17:44
@Defined2014
partition: support global index
fc3ce38
@Defined2014 @mjonss
Update partitioned-table.md
3cbe2e5 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@Defined2014 @mjonss
Update partitioned-table.md
db1ebf2 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@Defined2014 @mjonss
Apply suggestions from code review
b1e96dc 
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@Defined2014
update
5ed9b56
@Defined2014 @dveeden
Apply suggestions from code review
6e2a908 
Co-authored-by: Daniël van Eeden <github@myname.nl>
@Defined2014 @dveeden
Apply suggestions from code review
3997a3c 
Co-authored-by: Daniël van Eeden <github@myname.nl>
@Defined2014
add placement rules
5c189ac
@Defined2014
update
791deee
@Defined2014
update
a5729ca
@hfxsd
Apply suggestions from code review
6004f5e
@hfxsd
Update placement-rules-in-sql.md
c4842dc
@hfxsd
Update system-variables.md
58aa8a2
@mjonss
Updated with explicit GLOBAL attribute for global indexes
e2bf9e4
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2024
@hfxsd hfxsd self-requested a review August 9, 2024 03:18
@hfxsd hfxsd added v8.3 translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 12, 2024
@hfxsd hfxsd requested a review from Defined2014 August 12, 2024 04:33
Defined2014
Defined2014 reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2024

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjonss mjonss marked this pull request as ready for review August 12, 2024 07:00
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@hfxsd hfxsd mentioned this pull request Aug 12, 2024
Closed
19 tasks
hfxsd
hfxsd reviewed Aug 12, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 14, 2024
hfxsd
hfxsd reviewed Aug 14, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 August 14, 2024 04:30
@hfxsd hfxsd requested review from qiancai and removed request for lilin90 August 15, 2024 03:23
qiancai
qiancai reviewed Aug 15, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-index.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-table.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
partitioned-table.md Show resolved Hide resolved
hfxsd and others added 2 commits August 15, 2024 20:53
hfxsd
hfxsd reviewed Aug 15, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
@mjonss mjonss mentioned this pull request Aug 15, 2024
Open
21 tasks
qiancai
qiancai reviewed Aug 16, 2024
View reviewed changes
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
partitioned-table.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Aug 16, 2024

Rest LGTM

@hfxsd @qiancai
Apply suggestions from code review
6870196 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-19 05:51:31.049924481 +0000 UTC m=+158286.184374601: ☑️ agreed by qiancai.
  • 2024-08-19 05:52:37.150003808 +0000 UTC m=+158352.284453931: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Aug 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 46bc6b5 into pingcap:master Aug 19, 2024
9 checks passed
@hfxsd hfxsd mentioned this pull request Sep 18, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjonss @qiancai @hfxsd @Defined2014 @Frank945946