Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning,br: replaced black-white-list by table-filter (#3065) #3139

Merged
merged 6 commits into from
Jul 6, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3065 to release-3.1


What is changed, added or deleted? (Required)

This PR documented the "table filter" feature shared by all new TiDB ecosystem tools, superseding the old "black-white-list" feature. The documentation is heavily copied from https://github.com/pingcap/tidb-tools/blob/master/pkg/table-filter/README.md.

The feature is / will be available in

  • Lightning (v4.0.2, v3.1.3, v3.0.17)
  • BR (v4.0.0-rc, v3.1.0-rc)
  • Dumpling
  • CDC (v4.0.2)
  • (DM may also switch to this in the future.)

The Lightning docs have been revised for this. The existing "black-white-list" page has been redirected to the shared reference. ("black-white-list" still works but are no longer recommended. Therefore we don't bother to rename these into "block-allow-list")

The BR docs have been expanded to describe -f.

Dumpling is untouched, but whoever translating pingcap/docs-cn#3541 should point the link in --filter to this new document rather than the README.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions) (only BR and Lightning)
  • v3.0 (TiDB 3.0 versions) (only Lightning)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/large Changes of a large size. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. labels Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@kennytm please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs/invitations

@ran-huang
Copy link
Contributor

@kennytm PTAL at this commit 43c6e18 which involves some version split changes.

table-filter.md Outdated

The TiDB ecosystem tools operate on all the databases by default, but oftentimes only a subset is needed. For example, you only want to work with the schemas in the form of `foo*` and `bar*` and nothing else.

Since TiDB 4.0, all TiDB ecosystem tools share a common filter syntax to define subsets. This document describes how to use the table filter feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again maybe not refer to 4.0 here.

table-filter.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2020
@ti-srebot
Copy link
Contributor Author

@ran-huang,Thanks for your review.

@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit df3d964 into pingcap:release-3.1 Jul 6, 2020
@ran-huang ran-huang mentioned this pull request Jul 31, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants