Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Improve handling of START TRANSACTION with MySQL-like databases #309

Closed
dveeden opened this issue Jul 13, 2021 · 3 comments
Closed

Improve handling of START TRANSACTION with MySQL-like databases #309

dveeden opened this issue Jul 13, 2021 · 3 comments

Comments

@dveeden
Copy link
Contributor

dveeden commented Jul 13, 2021

Bug Report

The SQL query from sql.go has a version specific comment to only execute on MySQL 4.1.8.

query = "START TRANSACTION /*!40108 WITH CONSISTENT SNAPSHOT */"

However with Vitess and MemSQL/SingleStore seems to have the same issue.

I would suggest to run a START TRANSACTION without the version-specific comment if the original statement fails.

Also with --consistency none this still fails.

@SunRunAway
Copy link

I suggest we should do a full test for memsql/singlestore.

@dveeden
Copy link
Contributor Author

dveeden commented Jul 13, 2021

@dveeden
Copy link
Contributor Author

dveeden commented Jul 13, 2021

I suggest we should do a full test for memsql/singlestore.

Yes and maybe Vitess. But as Vitess has a set of MySQL servers as backend and dumping directly from those and combining the data should work. However that could complicate table names and might copy Vitess specific metadata that should have been excluded.

dveeden added a commit to dveeden/dumpling that referenced this issue Jul 14, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL.
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Jul 14, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Jul 19, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Jul 19, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Jul 23, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Aug 2, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
dveeden added a commit to dveeden/dumpling that referenced this issue Aug 2, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this issue Aug 3, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this issue Aug 3, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this issue Aug 3, 2021
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants