This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
fix concurrency problem #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 50.76% 51.94% +1.18%
==========================================
Files 17 17
Lines 1775 1829 +54
==========================================
+ Hits 901 950 +49
- Misses 811 813 +2
- Partials 63 66 +3 |
kennytm
reviewed
Jul 8, 2020
Comment on lines
13
to
17
| type globalMetadata struct { | ||
| logFile string | ||
| pos string | ||
| gtidSet string | ||
| buffer bytes.Buffer | ||
|
|
||
| filePath string | ||
| startTime time.Time | ||
| finishTime time.Time | ||
| filePath string | ||
| } |
There was a problem hiding this comment.
why change this to immediately write to a buffer?
There was a problem hiding this comment.
Because I think it's clearer.. WDYT?
kennytm
approved these changes
Jul 10, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* resolve consistency problem * support dump follower status for mysql and mariaDB * revise metadata save point * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* resolve consistency problem * support dump follower status for mysql and mariaDB * revise metadata save point * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* resolve consistency problem * support dump follower status for mysql and mariaDB * revise metadata save point * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* resolve consistency problem * support dump follower status for mysql and mariaDB * revise metadata save point * address comment
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* resolve consistency problem * support dump follower status for mysql and mariaDB * revise metadata save point * address comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
show slave statusinfo in metadata for mysql/mariaDB.lockwhen server type istidb.What is changed and how it works?
flush: lock tables -> record metadata -> get tables listFor consistency
lock: record metadata -> get tables list -> lock tablesmetadata.go.snapshotbefore addsnapshotsession variable.Check List
Tests
Manually check metadata for tidb/mysql. Looks fine to me.
Side effects
Release note