This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
fix unique key null bug #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 51.67% 51.48% -0.20%
==========================================
Files 17 17
Lines 1850 1853 +3
==========================================
- Hits 956 954 -2
- Misses 826 830 +4
- Partials 68 69 +1 |
kennytm
reviewed
Jul 10, 2020
Yes. This is used for the extreme situation. |
kennytm
approved these changes
Jul 14, 2020
overvenus
approved these changes
Jul 14, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the problem that when picked up field is unique index NULL but dumpling skipped the NULL value.
What is changed and how it works?
Add nullValueCondition to check for the first file like mydumper. A related integration is also added.
Check List
Tests
Related changes
Release note
--ris specified.