Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

dump: always split TiDB v4.* tables through tidb rowid to save TiDB's memory (#273) #280

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #273

What problem does this PR solve?

fix #104 and close #278

What is changed and how it works?

Split chunks by PKIsHandle for TiDB v4.0.*. Make sure TiDB won't OOM through splitting tables by rowids.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Test dump with v4.0.0. The result is looks expected.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Always split TiDB v4.* tables through tidb rowid to save TiDB's memory.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label May 11, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 33997cb

@lonng
Copy link

lonng commented May 25, 2021

/label cherry-pick-approved

@ti-chi-bot ti-chi-bot merged commit 9509923 into pingcap:release-5.0 May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants