Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

*: migrate test-infra to testify (#344) #347

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #344

What problem does this PR solve?

pingcap/check is no longer under maintenance, migrate to testify.

This PR can be somewhat regarded as a subtask of pingcap/tidb#26022

This closes #346 .

Release note

  • No release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Sep 7, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 41a8ac7

@ti-chi-bot ti-chi-bot merged commit 8109418 into pingcap:release-5.0 Sep 7, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.4, v5.0.6 Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants