model: add new field to explict charset&collation in ColumnInfo #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiekeyi98
commented
Feb 13, 2019
model/model.go
Outdated
| @@ -83,6 +83,7 @@ type ColumnInfo struct { | |||
| types.FieldType `json:"type"` | |||
| State SchemaState `json:"state"` | |||
| Comment string `json:"comment"` | |||
| ExplictedCollation bool `json:"explicted_collation"` | |||
There was a problem hiding this comment.
Any other better variable name ? I think this name is not good enough, but I cannot find a better name(avoid too long).
And I modeled the variable name of MYSQL(In MYSQL, this name is column_has_explicit_collation).
kennytm
reviewed
Feb 13, 2019
Co-Authored-By: xiekeyi98 <xiekeyi98@gmail.com>
|
I make something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
To solve pingcap/tidb#9113 , we need change ColumnInfo a little.
What is changed and how it works?
Add a field
ExplictedCollation.