Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drainer should support kafka clientID property #900

Closed
dixingxing0 opened this issue Feb 14, 2020 · 3 comments
Closed

Drainer should support kafka clientID property #900

dixingxing0 opened this issue Feb 14, 2020 · 3 comments
Labels
feature-request This issue is a feature request status/help-wanted

Comments

@dixingxing0
Copy link
Contributor

Feature Request

Describe the feature you'd like:
Our kafka cluster is authenticate by kafka clientID, since drainer do not support clientID property, we can't push binlog data to kafka cluster.
So drainer should support kafka clientID property in our scenario.
@dixingxing0 dixingxing0 added the feature-request This issue is a feature request label Feb 14, 2020
@WangXiangUSTC
Copy link
Contributor

We can add a new configuration for Drainer, just like the kafka-version

tidb-binlog/drainer/sync/util.go

Line 41 in 1239134

KafkaVersion string `toml:"kafka-version" json:"kafka-version"`

@dixingxing0
Copy link
Contributor Author

Thanks, I am working on this now, if test going well, i will submit a PR.

This was referenced Feb 14, 2020
Closed
Merged
@WangXiangUSTC
Copy link
Contributor

WangXiangUSTC commented Feb 17, 2020 •
edited
Loading

support in #902, thanks

@WangXiangUSTC WangXiangUSTC mentioned this issue Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request This issue is a feature request status/help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dixingxing0 @WangXiangUSTC