Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: add KafkaClientID in DBConfig #902

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

dixingxing0
Copy link
Contributor

Improve configuration for kafka syncer:
Add kafka-client-id in drainer.toml to config kafka client.id property.

What problem does this PR solve?

Drainer should support kafka clientID property #900

Improve configuration for kafka syncer:
Add kafka-client-id in drainer.toml to config kafka client.id property.
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

@WangXiangUSTC WangXiangUSTC merged commit 27fd5f7 into pingcap:master Feb 15, 2020
WangXiangUSTC pushed a commit that referenced this pull request Mar 6, 2020
Improve configuration for kafka syncer:
Add kafka-client-id in drainer.toml to config kafka client.id property.
WangXiangUSTC added a commit that referenced this pull request Mar 6, 2020
Improve configuration for kafka syncer:
Add kafka-client-id in drainer.toml to config kafka client.id property.

Co-authored-by: dixingxing <dixingxing@yeah.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants