Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix daily test case failure caused by auto_random #1037

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix daily test case failure caused by auto_random #1037

merged 1 commit into from
Mar 23, 2021

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 23, 2021 •
edited by lichunzhu
Loading

What problem does this PR solve?

workaround test case failure caused by pingcap/tidb#23235

What is changed and how it works?

add clustered

Check List

Tests

  • Unit test

Code changes

  • only test

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release branch 5.0

Release note

  • No release note

@lysu lysu changed the title Update case.go fix daily test case failure caused by auto_random Mar 23, 2021
@lysu lysu requested a review from july2993 March 23, 2021 05:25
@sre-bot
Copy link

sre-bot commented Mar 23, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@lysu lysu requested review from you06 and lichunzhu March 23, 2021 05:26
@lysu
Copy link
Contributor Author

lysu commented Mar 23, 2021

/cc @3pointer

@lysu
Copy link
Contributor Author

lysu commented Mar 23, 2021

@zhouqiang-cl this will fix https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/binlog_ghpr_integration/detail/binlog_ghpr_integration/2527/pipeline

@lysu
Copy link
Contributor Author

lysu commented Mar 23, 2021

/rebuild

lichunzhu
lichunzhu approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3pointer
Copy link
Contributor

LGTM

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Mar 23, 2021 •
edited
Loading

@lysu great, thank you very much

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-srebot
Copy link

@zhouqiang-cl Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: migrate(slack).

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl zhouqiang-cl mentioned this pull request Mar 23, 2021
Closed
@3pointer
Copy link
Contributor

/rebuild

1 similar comment
@3pointer
Copy link
Contributor

/rebuild

@3pointer
Copy link
Contributor

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl zhouqiang-cl merged commit 53a591e into master Mar 23, 2021
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
@ti-srebot
Copy link

cherry pick to release-5.0 in PR #1038

@ti-chi-bot ti-chi-bot deleted the workaround-to-fix-testcase branch April 11, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@july2993 july2993 Awaiting requested review from july2993

@you06 you06 Awaiting requested review from you06

Assignees
No one assigned
Labels
status/LGT1 type/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lysu @sre-bot @3pointer @zhouqiang-cl @ti-srebot @lichunzhu