Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: process empty string from tidb in update/delete statement on oracle #1163

Merged
merged 6 commits into from
May 25, 2022

Conversation

cartersz
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #1162

What is changed and how it works?

Check value of column , if it is empty string , drainer generate "col is null" clause in sql statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@cartersz
Copy link
Contributor Author

/run-all-tests

@cartersz
Copy link
Contributor Author

@lichunzhu PTAL

@lichunzhu
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dd7eb1c

@lichunzhu
Copy link
Contributor

/hold

@cartersz
Copy link
Contributor Author

/run-all-tests

1 similar comment
@cartersz
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor

/unhold

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 17b2b1b

@ti-chi-bot ti-chi-bot merged commit ca0eeed into pingcap:master May 25, 2022
@lichunzhu
Copy link
Contributor

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created: #1166.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants