pump: Extract function and add unit tests #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
july2993
reviewed
Mar 27, 2019
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
|
@suzaku you can just push new commits to address comment, so reviewer will be easy seeing what is update, currently we always use |
|
@july2993 OK, so I don't have to rebase myself. But with |
july2993
pushed a commit
that referenced
this pull request
Apr 10, 2019
july2993
added a commit
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refactor to make
NewAppendWithResolvera little shorterWhat is changed and how it works?
Extract a new function
openMetadataDBfromNewAppendWithResolverCheck List
Tests
Code changes
Side effects
Related changes