Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: remove pb compress config && change 'pb' to 'file' #575

Merged
merged 4 commits into from
May 5, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

  1. remove pb compress config
  2. change pb to file

What is changed and how it works?

cherry pick #559 and resolve conflicts, and then remove some code have nothing to do with this pr

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to be included in the release note

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@july2993
Copy link
Contributor

july2993 commented May 5, 2019

/run-unit-test

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku
Copy link
Contributor

suzaku commented May 5, 2019

LGTM

@july2993
Copy link
Contributor

july2993 commented May 5, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1

@july2993 july2993 merged commit eba829c into release-2.1 May 5, 2019
@july2993 july2993 deleted the xiang/cherry-pick1 branch May 5, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants