Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS to connect mysql/TiDB #894

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Support TLS to connect mysql/TiDB #894

merged 1 commit into from
Feb 12, 2020

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

fix #887

What is changed and how it works?

Add an according configure part syncer.to.security
use RegisterTLSConfig to registers a custom tls.Config to be used with sql.Open

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • enable TLS in drainer, fails to connect TiDB without enabling TLS.
    • after enable TLS, drainer success to connect to TiDB.

relate docs: https://pingcap.com/docs-cn/stable/how-to/secure/enable-tls-clients/

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@suzaku
Copy link
Contributor

suzaku commented Feb 12, 2020

/run-all-tests

suzaku
suzaku reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IANTHEREAL
IANTHEREAL approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL merged commit 1239134 into pingcap:master Feb 12, 2020
@july2993 july2993 deleted the mysql_tls branch February 13, 2020 05:46
july2993 added a commit that referenced this pull request Mar 15, 2020
@july2993
Support TLS to connect mysql/TiDB (#894)
7e30098
@july2993 july2993 mentioned this pull request Mar 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
need-update-docs needs-cherry-pick-release-3.0 status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support TLS in MySQL drainer
3 participants
@july2993 @suzaku @IANTHEREAL