address comment

pingcap · Mar 19, 2020 · 6aa0695 · 6aa0695
1 parent 9bb2aaf
commit 6aa0695
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/charts/tidb-lightning/templates/job.yaml b/charts/tidb-lightning/templates/job.yaml
@@ -43,8 +43,10 @@ spec:
         - |
 {{ tuple "scripts/_start_data_retriever.sh.tpl" . | include "helm-toolkit.utils.template" | indent 10 }}
         volumeMounts:
+        {{- if or .Values.dataSource.remote.rcloneConfig .Values.dataSource.remote.secretName}}
         - name: credentials
           mountPath: /etc/rclone
+        {{ end -}}
         - name: data
           mountPath: /data
       {{ if and (ne .Values.timezone "UTC") (ne .Values.timezone "") }}
@@ -125,12 +127,10 @@ spec:
           items:
           - key: config-file
             path: rclone.conf
-      {{ else }}
+      {{- else if .Values.dataSource.remote.secretName }}
       - name: credentials
         secret:
-          {{- if .Values.dataSource.remote.secretName}}
           secretName: {{ .Values.dataSource.remote.secretName }}
-          {{- end }}
       {{- end }}
       - name: data
         persistentVolumeClaim: