Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource limit to local-volume-provisioner #424

Closed
weekface opened this issue Apr 24, 2019 · 2 comments · Fixed by #569
Closed

Add resource limit to local-volume-provisioner #424

weekface opened this issue Apr 24, 2019 · 2 comments · Fixed by #569
Assignees
@cofyc

Comments

@weekface
Copy link
Contributor

We should give this Pod a QoS class of Guaranteed to avoid being killed by oom firstly.
@cofyc
Copy link
Contributor

cofyc commented Jun 11, 2019 •
edited
Loading

I think it's not necessary to give this pod a QoS class of Guaranteed to avoid being killed by OOM.
When the memory pressure of a node is high, it's meaningless to discover new or recycle old local volumes on that node. We can delay the operations of local volumes until the node recovers.

@cofyc
Copy link
Contributor

cofyc commented Jun 11, 2019 •
edited
Loading

Ah, I forgot one thing that it's not recommended to give DaemonSet pods a QoS of BestEffort because DaemonSet controller will recreate pods immediately. When a node is under pressure, DaemonSet pods may be evicted and rescheduled back repeatedly.

I'll submit a PR for this.

@cofyc cofyc mentioned this issue Jun 11, 2019
Merged
yahonda pushed a commit that referenced this issue Dec 27, 2021
@Yisaer @ti-srebot
zh: update the api-reference link (#424)
54760ec 
* Update TOC.md

* Delete api-references.md

* solve deadlink

* fix deadlink

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cofyc cofyc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give local-volume-provisioner pod a QoS of Guaranteed cofyc/tidb-operator
2 participants
@weekface @cofyc