Add switch to reclaim pv when scale in tikv or pd #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 22, 2019 02:41
aylei
reviewed
Oct 25, 2019
Co-Authored-By: Aylei <rayingecho@gmail.com>
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
…perator into add-switch-to-clean-pvc
|
/run-e2e-in-kind |
added 6 commits
November 3, 2019 15:10
…perator into add-switch-to-clean-pvc
|
/run-e2e-in-kind |
1 similar comment
|
/run-e2e-in-kind |
|
Can we add this feature to |
Yisaer
reviewed
Nov 5, 2019
cofyc
reviewed
Nov 5, 2019
| @@ -10,6 +10,7 @@ tests/images/e2e/tidb-cluster/ | |||
| tests/images/e2e/tidb-backup/ | |||
| tests/images/e2e/tidb-operator/ | |||
| tests/images/e2e/manifests/ | |||
| manifests/crd-verify.yaml | |||
There was a problem hiding this comment.
@Yisaer better to update verify script to use a temporary file
cofyc
reviewed
Nov 5, 2019
|
/run-e2e-in-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Resolve #908
What is changed and how does it work?
Add
enablePVReclaimoption incharts/tidbcluster/values.yaml，set this option totrueto enable PV reclaim function.Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: