Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AdvancedStatefulSet feature #1108

Merged
merged 6 commits into from
Nov 18, 2019
Merged

add AdvancedStatefulSet feature #1108

merged 6 commits into from
Nov 18, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Nov 5, 2019 •
edited
Loading

What problem does this PR solve?

fixes #1094

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

tidb-operator chart value `scheduler.features` is migrated to `features`

Does this PR introduce a user-facing change?:

add AdvancedStatefulset feature to use advanced statefulset instead of Kubernetes builtin statefulset

@cofyc
Copy link
Contributor Author

cofyc commented Nov 5, 2019

/run-e2e-in-kind

@cofyc cofyc changed the title add AdvancedStatefulSet feature WIP: add AdvancedStatefulSet feature Nov 5, 2019
@cofyc
Copy link
Contributor Author

cofyc commented Nov 5, 2019

/run-e2e-in-kind

gregwebs
gregwebs reviewed Nov 5, 2019
View reviewed changes
charts/tidb-operator/templates/advanced-statefulset-deployment.yaml Outdated
spec:
containers:
- name: advanced-statefulset-controller
image: quay.io/cofyc/advanced-statefulset:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this under pingcap now? Including the github repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, when this solution works well

@cofyc
Copy link
Contributor Author

cofyc commented Nov 5, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 5, 2019

/run-e2e-in-kind

2 similar comments
@cofyc
Copy link
Contributor Author

cofyc commented Nov 5, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

tennix
tennix reviewed Nov 6, 2019
View reviewed changes
charts/tidb-operator/templates/advanced-statefulset-rbac.yaml Outdated
kind: RoleBinding
metadata:
name: advanced-statefulset-controller
namespace: kube-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this ns is kube-system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing only, this controller does not support specifying namespace (working on it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

4 similar comments
@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc cofyc force-pushed the fix1094 branch 2 times, most recently from 13d75c9 to 4fcb16e Compare November 6, 2019 12:37
@cofyc
Copy link
Contributor Author

cofyc commented Nov 6, 2019

/run-e2e-in-kind

@cofyc cofyc force-pushed the fix1094 branch 2 times, most recently from 3b5ccbd to 9c7d6fd Compare November 7, 2019 06:53
@cofyc
Copy link
Contributor Author

cofyc commented Nov 7, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 7, 2019

/run-e2e-in-kind

cofyc
cofyc commented Nov 7, 2019
View reviewed changes
hack/kind-cluster-build.sh Outdated
@@ -62,7 +62,7 @@ done
clusterName=${clusterName:-kind}
nodeNum=${nodeNum:-6}
k8sVersion=${k8sVersion:-v1.12.8}
volumeNum=${volumeNum:-9}
volumeNum=${volumeNum:-32}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

able to run e2e tests in a small cluster

DanielZhangQD
DanielZhangQD reviewed Nov 14, 2019
View reviewed changes
charts/tidb-operator/values.yaml Outdated
Comment on lines 164 to 165
# This will default to matching your kubernetes version
# kubeSchedulerImageTag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these comments be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

1 similar comment
@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

3 similar comments
@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 14, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor Author

cofyc commented Nov 15, 2019

@tennix @weekface @DanielZhangQD @onlymellb PTAL again.

tennix
tennix approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DanielZhangQD
DanielZhangQD approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor Author

cofyc commented Nov 18, 2019

/run-e2e-in-kind

@cofyc cofyc closed this Nov 18, 2019
@cofyc cofyc reopened this Nov 18, 2019
weekface
weekface approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 7164ba9 into pingcap:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregwebs gregwebs gregwebs left review comments

@onlymellb onlymellb onlymellb left review comments

@aylei aylei aylei left review comments

@weekface weekface weekface approved these changes

@tennix tennix tennix approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use AdvancedStatefulSet CRD to replace Kubernetes StatefulSet
7 participants
@cofyc @aylei @gregwebs @weekface @tennix @onlymellb @DanielZhangQD