Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: upgrade base image to alpine 3.10 #1178

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

AstroProfundis
Copy link
Contributor

The 3.5 images are not maintained by upstream anymore, and 3.10 is
the latest stable branch.

What problem does this PR solve?

Upgrade base image of docker images to Alpine 3.10.x

What is changed and how does it work?

Upgrade base image in Dockerfiles

Check List

Tests

  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has CI related scripts change

Side effects

  • Assumed to be none

Related changes

  • Stability tests might be needed

Does this PR introduce a user-facing change?:

Upgrade base system of docker images to latest stable

The 3.5 images are not maintained by upstream anymore, and 3.10 is
the latest stable branch.
@aylei
Copy link
Contributor

aylei commented Nov 18, 2019

/run-e2e-in-kind

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Nov 19, 2019

/run-e2e-test

@cofyc
Copy link
Contributor

cofyc commented Nov 19, 2019

/run-e2e-test

@cofyc
Copy link
Contributor

cofyc commented Nov 20, 2019

/run-e2e-test

@tennix
Copy link
Member

tennix commented Nov 20, 2019

/run-e2e-test

@tennix tennix merged commit 42a1254 into pingcap:master Nov 20, 2019
@AstroProfundis AstroProfundis deleted the upgrade-base-image branch November 21, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants