Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resign ddl owner logic for tidb-servers #1239

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Nov 26, 2019

Signed-off-by: Aylei rayingecho@gmail.com

close #1225

Check List

Tests

  • E2E test

Code changes

  • Has Go code change

Does this PR introduce a user-facing change?:

Operator will not resign ddl owner when upgrading tidb-servers anymore because tidb-server will transfer ddl owner automatically on shutdown.

@aylei
Copy link
Contributor Author

aylei commented Nov 26, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Nov 26, 2019

webhook in e2e should be updated too because it validates that pod to delete should not be DDL owner

@aylei
Copy link
Contributor Author

aylei commented Nov 26, 2019

webhook in e2e should be updated too because it validates that pod to delete should not be DDL owner

Thanks, working on it

@aylei
Copy link
Contributor Author

aylei commented Nov 26, 2019

/run-e2e-in-kind

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Nov 26, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Nov 26, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Nov 27, 2019

@weekface @cofyc @tennix PTAL

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Nov 27, 2019

/run-e2e-in-kind

@aylei aylei merged commit 7221998 into pingcap:master Nov 27, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove resign DDL owner logic to keep things simple
4 participants