sync pd and tikv configmap in controller #1330
Conversation
|
/run-e2e-test |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-test |
| @@ -250,7 +246,7 @@ type PDScheduleConfig struct { | |||
| // MaxStoreDownTime is the max duration after which | |||
| // a store will be considered to be down if it hasn't reported heartbeats. | |||
| // +optional | |||
| MaxStoreDownTime Duration `toml:"max-store-down-time,omitempty" json:"max-store-down-time,omitempty"` | |||
| MaxStoreDownTime string `toml:"max-store-down-time,omitempty" json:"max-store-down-time,omitempty"` | |||
There was a problem hiding this comment.
BurntSushi/toml do not respect MarshalText, use string instead
There was a problem hiding this comment.
BurntSushi/toml seems not maintained anymore...
we can use https://github.com/pelletier/go-toml and implement toml.MarshalTOML() (like MarshalJSON())
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, that's exactly what I've thought.
Actually I've tried go-toml( and naoina/toml), it turns out that go-toml does not support interface{} (necessary for schemaless configuration, e.g. Pump). Also, PD and TiDB uses BurntSushi/toml so there is little verifying work, seems like that BurntSushi/toml is not an ideal but the only choice
|
/run-e2e-test |
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
close #1263
close #1264
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: