Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade tidb-cloud-backup image and optimize default backup options #1360

Merged
merged 5 commits into from
Dec 20, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Dec 18, 2019

Signed-off-by: Aylei rayingecho@gmail.com

close #1351

New option -r has better performance than -F, benched on a 50G data set, -F 256 takes 19m29s and -r 10000 takes 14m29s.

Check List

Tests

  • E2E test
  • Manual test (add detailed scripts or steps below)

Does this PR introduce a user-facing change?:

Upgrade the default backup image to pingcap/tidb-cloud-backup:20191217 and facilitate -r option

@weekface @tennix @cofyc @DanielZhangQD PTAL

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Dec 18, 2019

/run-e2e-test

@aylei
Copy link
Contributor Author

aylei commented Dec 18, 2019

/run-e2e-test

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei requested a review from Yisaer December 19, 2019 13:31
@aylei
Copy link
Contributor Author

aylei commented Dec 19, 2019

/run-e2e-test

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer Yisaer merged commit 7dc8bcc into pingcap:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade default tidb-cloud-backup image and optimize options
3 participants