Update eks version in deploy scripts #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2020 14:18
|
/run-e2e-in-kind |
1 similar comment
|
/run-e2e-in-kind |
|
/run-e2e-test |
|
/run-e2e-in-kind |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
cofyc
reviewed
Apr 22, 2020
| @@ -14,12 +14,12 @@ variable "eks_name" { | |||
|
|
|||
| variable "eks_version" { | |||
| description = "Kubernetes version to use for the EKS cluster." | |||
| default = "1.12" | |||
| default = "1.15" | |||
There was a problem hiding this comment.
is it possible to use the platform default value? if users do not specify it explicitly, the default kubernetes version in AWS will be used.
There was a problem hiding this comment.
IMO，using default or latest value is not stable. It may work well current time but encounter some problem when aws platform decided to update the version like this time( psp problem).
cofyc
approved these changes
Apr 22, 2020
|
cherry pick to release-1.1 in PR #2268 |
cofyc
pushed a commit
that referenced
this pull request
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #2173
Update the default eks version in terraform scripts as 1.15
As psp is enabled after eks 1.13, I add init annotation for tidb to initialize
sysctlto avoiding pod create failed due to psp. FYI: https://docs.aws.amazon.com/eks/latest/userguide/pod-security-policy.htmlDoes this PR introduce a user-facing change?: