Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statefulsets are updated during each sync even if no changes to the config (#2308) #2325

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 28, 2020

cherry-pick #2308 to release-1.1


What problem does this PR solve?

statefulsets are updated during each sync even if no changes to the config

What is changed and how does it work?

Fix the equality check logic

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Check tidb-controller-manager logs that statefulsets are not updated without changes to the config

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Fix the issue that statefulsets are updated during each sync even if no changes to the config

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3b3fa82 into pingcap:release-1.1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants