Fixed syntax for "and" conditions #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a deployment error. ``` <(.Values.monitor.create) and (.Values.monitor.grafana.create)>: can't give argument to non-function .Values.monitor.create ``` We have confirmed that both helm2[1] and helm3[2] work. [1]: https://v2.helm.sh/docs/chart_template_guide/#operators-are-functions [2]: https://helm.sh/docs/chart_template_guide/function_list/#and
|
|
|
/run-all-tests |
|
/merge |
|
Sorry @DanielZhangQD, you don't have permission to trigger auto merge event on this branch. The number of |
|
@8398a7 Thanks for your contribution! |
|
/run-all-tests |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #2877 |
ti-srebot
added a commit
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes a deployment error. (#2867)
I have confirmed that both helm2 and helm3 work.
https://v2.helm.sh/docs/chart_template_guide/#operators-are-functions
https://helm.sh/docs/chart_template_guide/function_list/#and
What is changed and how does it work?
Fixed syntax.
Check List
Tests
I used a v1.16 series k8s cluster.
The following command is used to check the operation.
Code changes
Related changes
None.
Does this PR introduce a user-facing change?:
No.