Change binlog/enable from bool to string #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change 0dada1ec37df88d0bcdc6b6cf687407ba9393d6f to tidb made binlog/enable a string instead of bool.
|
|
|
We cannot merge this: we need a way to know whether we are using TiDB 2.0 or 3.0 and change the configuration file format appropriately. I made a request to TiDB to maintain backwards compatibility: pingcap/tidb#9686 |
|
Yes, if pingcap/tidb#9688 get merged, then the configuration file doesn't need to be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 0dada1ec37df88d0bcdc6b6cf687407ba9393d6f to tidb made binlog/enable a string instead of bool.