Yinliang/backup and restore add adhoc backup and restore functison #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "mode": "restore", | ||
| "user": "root", | ||
| "password": to.Password, | ||
| "storage.size": "10Gi", |
There was a problem hiding this comment.
10Gi may be too small for backup job
There was a problem hiding this comment.
this setting just suit for my cluster, We can modify it during stress testing。
weekface
reviewed
Mar 14, 2019
tests/cmd/e2e/main.go
Outdated
| Image: "pingcap/tidb-operator:v1.0.0-beta.1-p2", | ||
| Tag: "v1.0.0-beta.1-p2", | ||
| Image: "pingcap/tidb-operator:latest", | ||
| Tag: "latest", |
zyguan
reviewed
Mar 14, 2019
tests/actions.go
Outdated
| return false, nil | ||
| } | ||
| if job.Status.Succeeded == 0 { | ||
| glog.Error("cluster [%s] back up job is not completed, please wait! ", to.ClusterName) |
| return 0, err | ||
| } | ||
|
|
||
| rows, err := db.Query(fmt.Sprintf("SELECT count(*) FROM %s", tableName)) |
There was a problem hiding this comment.
var count int
if err := db.QueryRaw(...).Scan(&count); err != nil {
...
}
return count, nilotherwise, you have to close rows.
There was a problem hiding this comment.
It seems all right， I‘ll change it in next PR.
weekface
approved these changes
Mar 15, 2019
weekface
pushed a commit
to weekface/tidb-operator
that referenced
this pull request
Mar 21, 2019
…ingcap#316) * add restore and backup process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.add create secret process
2.add bakcup process
3.add restore process
4.add some parameters via the values.yaml change.
5.use master branch to test
@weekface @zyguan @cwen0 @xiaojingchen PTAL