fix local dind env #440
fix local dind env #440
Conversation
* fix dind document * rm manifests/local-dind/pv-create.sh manifests/local-dind/pv-hosts.sh and hack/dind-run-operators.sh
| @@ -2401,7 +2401,7 @@ function dind::run_tiller { | |||
| if [[ $? -eq 0 ]];then | |||
| helm_version=$(helm version -c --template '{{.Client.SemVer}}') | |||
| if [[ -n ${KUBE_REPO_PREFIX} ]];then | |||
| helm init --tiller-image ${KUBE_REPO_PREFIX}/tiller:${helm_version} | |||
| helm init --tiller-image ${KUBE_REPO_PREFIX}/tiller:${helm_version} --skip-refresh | |||
There was a problem hiding this comment.
Why do you want to add this parameter ? Just want to skip downloading the stable repo's index.yaml file ? refer this code.
There was a problem hiding this comment.
Yes, just to skip the download of the index.yaml file on https://kubernetes-charts.storage.googleapis.com. It is blocked that you understand.
hack/dind-run-operators.sh
Outdated
| @@ -1,8 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
It is useful for me to have a bash script rather than doing a copy and paste from the tutorial.
There was a problem hiding this comment.
this script is out of date, it will include ./manifests/local-dind/setup.sh -> ./manifests/local-dind/pv-hosts.sh -> ./manifests/local-dind/pv-create.sh.
but the pv create is replaced by manifests/local-dind/dind-cluster-v1.12.sh.
and many users use pv-create.sh in their production setup, this is dangerous.
So we may better use this document for local dind setup instead.
There was a problem hiding this comment.
Yes, the script is out of date. Can we update it to use the commands in that document?
manifests/local-dind/dind-cluster-v1.12.sh up
kubectl apply -f manifests/crd.yaml
helm install charts/tidb-operator --name=tidb-operator --namespace=tidb-admin
helm install charts/tidb-cluster --name=demo --namespace=tidb
|
/run-e2e-tests |
|
@onlymellb @gregwebs ptal |
| @@ -48,8 +48,7 @@ NAME AGE | |||
| tidbclusters.pingcap.com 1m | |||
|
|
|||
| $ # Install TiDB Operator into Kubernetes | |||
| $ helm install charts/tidb-operator --name=tidb-operator --namespace=tidb-admin | |||
|
|
|||
| $ helm install charts/tidb-operator --name=tidb-operator --namespace=tidb-admin --set scheduler.kubeSchedulerImageName=mirantis/hypokube --set scheduler.kubeSchedulerImageTag=final | |||
There was a problem hiding this comment.
Why not change it in values.yaml directly?
There was a problem hiding this comment.
This is a tutorial, it's easier for users to copy/paste.
What problem does this PR solve?
and hack/dind-run-operators.sh
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes