AWS EKS tutorial change to new terraform script #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennix
reviewed
May 8, 2019
jlerche
force-pushed
the
aws-terraform-reuse-tutorial
branch
from
f1e8417
to
ef02163
Compare
aylei
approved these changes
May 9, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* zh: fix a DNS debugging link * Update zh/troubleshoot.md Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This will close #450 and #445
What is changed and how it works?
Some extra variables were extracted to accommodate a lighter-weight deployment re-purposed for the AWS EKS tutorial. The values specific to the tutorial are stored in a separate terraform variables file, defaults were kept the same.
The pd and tikv userdata script was unified into a single script.
Check List
Tests
Checked that tutorial deployment works as expected
Checked that default deployment works as expected
Code changes
Side effects
Related changes