New stability test case for ConfigMap rollout #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
…ration check instead Signed-off-by: Aylei <rayingecho@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
aylei
commented
May 21, 2019
| @@ -9,6 +9,9 @@ | |||
| # | |||
|
|
|||
| set -uo pipefail | |||
|
|
|||
| {{ .Values.pd.preStartScript }} | |||
aylei
commented
May 21, 2019
tests/actions.go
Outdated
| @@ -328,6 +336,7 @@ func (oi *OperatorConfig) OperatorHelmSetString(m map[string]string) string { | |||
| "scheduler.logLevel": "2", | |||
| "controllerManager.replicas": "2", | |||
| "scheduler.replicas": "2", | |||
| "imagePullPolicy": "Always", | |||
There was a problem hiding this comment.
Typically, we will use the latest tag of operator image. Always can avoid using stale image
aylei
commented
May 21, 2019
| @@ -1593,7 +1602,7 @@ func releaseIsNotFound(err error) bool { | |||
| } | |||
|
|
|||
| func (oa *operatorActions) cloneOperatorRepo() error { | |||
| cmd := fmt.Sprintf("git clone https://github.com/pingcap/tidb-operator.git %s", oa.cfg.OperatorRepoDir) | |||
| cmd := fmt.Sprintf("git clone %s %s", oa.cfg.OperatorRepoUrl, oa.cfg.OperatorRepoDir) | |||
There was a problem hiding this comment.
If the developers modify the chart in their development branch, they have to configure the git url in order to test the chart modification
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
|
/run-e2e-tests |
onlymellb
reviewed
May 24, 2019
| @@ -51,6 +52,7 @@ func main() { | |||
| WebhookServiceName: "webhook-service", | |||
| WebhookSecretName: "webhook-secret", | |||
| WebhookConfigName: "webhook-config", | |||
| ImagePullPolicy: v1.PullIfNotPresent, | |||
There was a problem hiding this comment.
The ImagePullPolicy can be omitted. It is set to IfNotPresent by default.
There was a problem hiding this comment.
If I understand correctly, according to the communication in this morning, IfNotPresent is required for e2e test so I think it's better to enforce this policy explicitly.
xiaojingchen
approved these changes
May 24, 2019
|
/run-e2e-test |
1 similar comment
|
/run-e2e-test |
|
/run-e2e-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #486
What is changed and how it works?
New stability test case
Check List
Tests
@weekface @xiaojingchen @tennix @onlymellb PTAL