make webhook configurable #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
|
@xiaojingchen @onlymellb PTAL |
manifests/create-cert.sh
Outdated
| while [[ $# -gt 0 ]]; do | ||
| case ${1} in | ||
| --namespace) | ||
| namespace="$2" |
There was a problem hiding this comment.
Suggested change
| namespace="$2" | |
| namespace="${2}" |
There was a problem hiding this comment.
It seems the same ……
|
@onlymellb please take a look. |
onlymellb
reviewed
May 29, 2019
manifests/create-cert.sh
Outdated
| EOF | ||
| exit 1 | ||
| } | ||
|
|
||
| namespace=default | ||
| while [[ $# -gt 0 ]]; do |
There was a problem hiding this comment.
Refer here to implement shell parameter parsing
onlymellb
reviewed
May 29, 2019
manifests/create-cert.sh
Outdated
| done | ||
|
|
||
|
|
||
| [ -z ${namespace} ] && namespace=default |
There was a problem hiding this comment.
Use namespace=${namespace:-default} instead.
There was a problem hiding this comment.
I think we should default to tidb-admin namespace.
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
May 30, 2019
|
/run-e2e-tests |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add enterprise usage * address comments * address comments * address comments * add tidb-binlog enterprise image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make webhook configurable
What is changed and how it works?
Use shell script to patch namespace to webhook.yaml
Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?:
None