Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use staticcheck instead of megacheck #548

Merged
merged 1 commit into from
Jun 3, 2019
Merged

use staticcheck instead of megacheck #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ test:
@echo "Run unit tests"
@$(GOTEST) ./pkg/... -coverprofile=coverage.txt -covermode=atomic && echo "\nUnit tests run successfully!"

check-all: lint check-static check-shadow check-gosec megacheck errcheck
check-all: lint check-static check-shadow check-gosec staticcheck errcheck

check-setup:
@which retool >/dev/null 2>&1 || go get github.com/twitchtv/retool
Expand All @@ -99,11 +99,11 @@ check-static:
--enable ineffassign \
$$($(PACKAGE_DIRECTORIES))

# TODO: megacheck is too slow currently
megacheck:
@echo "gometalinter megacheck"
# TODO: staticcheck is too slow currently
staticcheck:
@echo "gometalinter staticcheck"
CGO_ENABLED=0 retool do gometalinter.v2 --disable-all --deadline 120s \
--enable megacheck \
--enable staticcheck \
$$($(PACKAGE_DIRECTORIES))

# TODO: errcheck is too slow currently
Expand Down
4 changes: 2 additions & 2 deletions tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"Commit": "7bae11eba15a3285c75e388f77eb6357a2d73ee2"
},
{
"Repository": "honnef.co/go/tools/cmd/megacheck",
"Commit": "88497007e8588ea5b6baee991f74a1607e809487"
"Repository": "honnef.co/go/tools/cmd/staticcheck",
"Commit": "5a4a2f4a438d01ba03c591f88ef312005a05063b"
},
{
"Repository": "github.com/kisielk/errcheck",
Expand Down