Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add privileged option for tikv pod template #550

Merged
merged 4 commits into from
Jun 3, 2019

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Jun 3, 2019

What problem does this PR solve?

we need to start fuse serve in tikv pod, so privileged option is necessary for me

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change

Side effects

  • Breaking backward compatibility

Does this PR introduce a user-facing change?:

add the privileged option for TiKV pod 

@cwen0 cwen0 requested a review from xiaojingchen June 3, 2019 08:27
weekface
weekface previously approved these changes Jun 3, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Jun 3, 2019

/run-e2e-tests

@cwen0
Copy link
Member Author

cwen0 commented Jun 3, 2019

/run-e2e-tests

@cwen0 cwen0 merged commit 758c988 into pingcap:master Jun 3, 2019
@cwen0 cwen0 deleted the tikv_add_privileged branch June 3, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants