Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate slow log with tidb server log by default #610

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Jun 27, 2019

What problem does this PR solve?

Separate slow query log with normal TiDB server log by default
Close #582

What is changed and how does it work?

Set "separateSlowLog: true" in values.yaml of tidb-cluster chart

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Helm charts change
  • Has documents change

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Jun 30, 2019

@DanielZhangQD Please sign the CLA.

@tennix tennix merged commit 31b75b8 into pingcap:master Jul 1, 2019
@DanielZhangQD DanielZhangQD deleted the separate-slow-log branch July 1, 2019 06:17
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable TiDB slow log by default
5 participants