Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --features flags and enable StableScheduling by default #677

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jul 22, 2019

What problem does this PR solve?

Enable StableScheduling by default.

What is changed and how does it work?

  • Update feature gates to support key={true,false} syntax
    • This is required to disable a feature e.g. StableScheduling=false.
  • Enable StableScheduling by default

Check List

Tests

  • Unit test
  • E2E test
  • Stability test

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has documents change

Side effects

  • Should pass =true

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

ACTION REQUIRED: tidb-scheduler --features flag has been updated to use `key={true,false}` format, please append `=true` to enable the feature.

@cofyc
Copy link
Contributor Author

cofyc commented Jul 22, 2019

/run-e2e-tests

@weekface weekface added this to the v1.0.0 milestone Jul 22, 2019
@weekface weekface merged commit b4342d6 into pingcap:master Jul 23, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
- Enable StableScheduling by default

(cherry picked from commit b4342d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants