Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default TiDB version to v3.0.4 #837

Merged
merged 8 commits into from
Oct 10, 2019
Merged

Conversation

shonge
Copy link
Member

@shonge shonge commented Aug 28, 2019

What problem does this PR solve?

upgrade default TiDB version to v3.0.4

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test

Code changes

  • Has Helm charts change
  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

ACTION REQUIRED: upgrade default TiDB version to v3.0.4

tests/config.go Outdated Show resolved Hide resolved
@weekface
Copy link
Contributor

/run-e2e-in-kind

add tidb-version v3.0.0 test support

Co-Authored-By: weekface <weekface@gmail.com>
@shonge
Copy link
Member Author

shonge commented Aug 28, 2019

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Sep 9, 2019

3.0.3 is released (https://github.com/pingcap/tidb/releases/tag/v3.0.3), can you update it to use 3.0.3? Thanks!

@cofyc
Copy link
Contributor

cofyc commented Oct 8, 2019

some conflicts must be resolved

@shonge shonge changed the title Upgrade default TiDB version to v3.0.2 Upgrade default TiDB version to v3.0.4 Oct 9, 2019
@tennix
Copy link
Member

tennix commented Oct 9, 2019

tidb-monitor-initializer v3.0.4 is not available yet, @qiffang please upgrade the tidb-monitor-initializer to the latest release version v3.0.4.

tests/config.go Outdated Show resolved Hide resolved
@@ -397,8 +397,8 @@ monitor:
storageClassName: local-storage
storage: 10Gi
initializer:
image: pingcap/tidb-monitor-initializer:v3.0.1
imagePullPolicy: Always
image: pingcap/tidb-monitor-initializer:v3.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiffang there is no pingcap/tidb-monitor-initializer:v3.0.4 yet. PTAL

tests/manifests/e2e/e2e.yaml Outdated Show resolved Hide resolved
tennix
tennix previously approved these changes Oct 9, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shonge shonge requested review from tennix and weekface October 9, 2019 03:29
weekface
weekface previously approved these changes Oct 9, 2019
tests support v3.0.2-3.0.4

Co-Authored-By: weekface <weekface@gmail.com>
@shonge shonge dismissed stale reviews from weekface and tennix via 3dd24ab October 9, 2019 05:47
e2e test support v3.0.2-v3.0.4

Co-Authored-By: weekface <weekface@gmail.com>
@weekface
Copy link
Contributor

weekface commented Oct 9, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit b150d31 into pingcap:master Oct 10, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* en: Improve deploy tidb monitor docs

* Update pd-recover.md

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* Update monitor-a-tidb-cluster.md

* align Chinese pr

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants