Add more columns for tkctl get tikv #842

Yisaer · 2019-08-29T06:18:09Z

What problem does this PR solve?

add storeid column for tkctl when type get tikv
#564

What is changed and how does it work?

Add type alias for Tikv v1.Pod and registered 2 new printer handlers so that tkctl will only add STOREID column when tkctl get tikv only

Check List

Tests

Manual test

Code changes

Has Go code change

Side effects

N/A

Related changes

N/A

Does this PR introduce a user-facing change?:

`tkctl get tikv` add `STOREID` column to show store id for each tikv pod

CLAassistant · 2019-08-29T06:18:14Z

All committers have signed the CLA.

pkg/tkctl/readable/printers.go

Yisaer · 2019-09-04T09:39:06Z

Here is the result the tkctl get tikv will look lile for this PR.

$ ./tkctl get tikv
NAME          READY   STATUS    MEMORY          CPU             RESTARTS   AGE    STOREID
tidb-tikv-0   1/1     Running   <none>/<none>   <none>/<none>   1          8d     4
tidb-tikv-1   1/1     Running   <none>/<none>   <none>/<none>   1          8d     1
tidb-tikv-2   1/1     Running   <none>/<none>   <none>/<none>   1          8d     5
tidb-tikv-3   1/1     Running   <none>/<none>   <none>/<none>   0          16h    1001
tidb-tikv-4   1/1     Running   <none>/<none>   <none>/<none>   0          16h    1002
tidb-tikv-5   1/1     Running   <none>/<none>   <none>/<none>   0          12h    1003
tidb-tikv-6   1/1     Running   <none>/<none>   <none>/<none>   0          164m   1006
tidb-tikv-7   1/1     Running   <none>/<none>   <none>/<none>   0          164m   1037
tidb-tikv-8   1/1     Running   <none>/<none>   <none>/<none>   0          163m   1038

gregwebs · 2019-09-06T01:29:51Z

@aylei PTAL

cofyc · 2019-09-10T01:33:35Z

/run-e2e-in-kind

pkg/tkctl/readable/printers.go

Co-Authored-By: weekface <weekface@gmail.com>

cofyc

SGTM

Yisaer · 2019-09-12T02:52:43Z

/run-e2e-in-kind

weekface

LGTM

aylei

LGTM

aylei · 2019-09-12T03:20:12Z

/run-e2e-in-kind

Yisaer · 2019-09-12T03:42:22Z

/run-e2e-in-kind

Yisaer · 2019-09-12T04:26:01Z

/run-e2e-test

cofyc · 2019-09-12T04:56:01Z

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/operator_ghpr_e2e_test_kind/detail/operator_ghpr_e2e_test_kind/289/pipeline

[2019-09-12T04:26:57.677Z] ++ /root/go/bin/kind get kubeconfig-path --name=kind4

[2019-09-12T04:26:57.677Z] + export KUBECONFIG=/root/.kube/kind-config-kind4

[2019-09-12T04:26:57.677Z] + KUBECONFIG=/root/.kube/kind-config-kind4

[2019-09-12T04:26:57.677Z] + elapseTime=0

[2019-09-12T04:26:57.677Z] + period=5

[2019-09-12T04:26:57.677Z] + threshold=300

[2019-09-12T04:26:57.677Z] + kubectl delete -f tests/manifests/e2e/e2e.yaml

[2019-09-12T04:26:58.241Z] unable to recognize "tests/manifests/e2e/e2e.yaml": Get https://127.0.0.1:46217/api?timeout=32s: dial tcp 127.0.0.1:46217: connect: connection refused

[2019-09-12T04:26:58.241Z] unable to recognize "tests/manifests/e2e/e2e.yaml": Get https://127.0.0.1:46217/api?timeout=32s: dial tcp 127.0.0.1:46217: connect: connection refused

[2019-09-12T04:26:58.241Z] unable to recognize "tests/manifests/e2e/e2e.yaml": Get https://127.0.0.1:46217/api?timeout=32s: dial tcp 127.0.0.1:46217: connect: connection refused

[2019-09-12T04:26:58.241Z] unable to recognize "tests/manifests/e2e/e2e.yaml": Get https://127.0.0.1:46217/api?timeout=32s: dial tcp 127.0.0.1:46217: connect: connection refused

@xiaojingchen kind4 is not working now?

aylei

LGTM

Yisaer · 2019-09-12T06:20:09Z

/run-e2e-in-kind

Yisaer · 2019-09-12T06:43:20Z

/run-e2e-test

* en: Improve self-hosted k8s deployment * Update deploy-tidb-operator.md * Update deploy-tidb-operator.md * Update prerequisites.md * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>

Song Gao added 4 commits August 29, 2019 12:44

Create alias.go

454140a

add extra print handler

eb6f6d9

add note

b7cc920

fix switch default

3a2a4f5

Yisaer marked this pull request as ready for review August 29, 2019 06:19

Merge branch 'master' into add_dedicated_columns_for_tikv_get

252521e

Yisaer closed this Aug 29, 2019

pull latest tkctl code

9d17e4c

Yisaer reopened this Aug 29, 2019

Song Gao and others added 3 commits August 29, 2019 15:21

Update get.go

857f329

Update get.go

37051e1

Merge branch 'master' into add_dedicated_columns_for_tikv_get

95fae5e

Yisaer changed the title ~~Add dedicated columns for tikv get~~ Add dedicated columns for tkctl get tikv Aug 29, 2019

Yisaer changed the title ~~Add dedicated columns for tkctl get tikv~~ Add more columns for tkctl get tikv Aug 29, 2019

onlymellb reviewed Aug 29, 2019

View reviewed changes

pkg/tkctl/readable/printers.go Outdated Show resolved Hide resolved

onlymellb reviewed Aug 29, 2019

View reviewed changes

pkg/tkctl/readable/printers.go Outdated Show resolved Hide resolved

Song Gao and others added 3 commits August 29, 2019 18:05

use label definition

586db18

fix printTikv func Into private

8259656

Merge branch 'master' into add_dedicated_columns_for_tikv_get

12946db

gregwebs requested a review from aylei August 30, 2019 14:07

Merge branch 'master' into add_dedicated_columns_for_tikv_get

f6d7f95

weekface reviewed Sep 10, 2019

View reviewed changes

pkg/tkctl/readable/printers.go Outdated Show resolved Hide resolved

pkg/tkctl/readable/printers.go Outdated Show resolved Hide resolved

Yisaer and others added 2 commits September 10, 2019 10:57

Update pkg/tkctl/readable/printers.go

cfe0579

Co-Authored-By: weekface <weekface@gmail.com>

Update pkg/tkctl/readable/printers.go

7fd2fb7

Co-Authored-By: weekface <weekface@gmail.com>

cofyc previously approved these changes Sep 10, 2019

View reviewed changes

weekface previously approved these changes Sep 10, 2019

View reviewed changes

Song Gao added 2 commits September 11, 2019 15:11

use type convert

bb326dc

fix

fd0c419

Yisaer dismissed stale reviews from weekface and cofyc via fd0c419 September 12, 2019 02:52

Yisaer requested review from aylei, cofyc and weekface September 12, 2019 02:59

cofyc previously approved these changes Sep 12, 2019

View reviewed changes

weekface previously approved these changes Sep 12, 2019

View reviewed changes

aylei previously approved these changes Sep 12, 2019

View reviewed changes

go fmt fix

b92987f

Yisaer dismissed stale reviews from aylei, weekface, and cofyc via b92987f September 12, 2019 03:42

Yisaer requested review from aylei and cofyc September 12, 2019 05:15

cofyc approved these changes Sep 12, 2019

View reviewed changes

aylei approved these changes Sep 12, 2019

View reviewed changes

Merge branch 'master' into add_dedicated_columns_for_tikv_get

eef5a9c

cofyc merged commit fbf20bc into pingcap:master Sep 12, 2019

Yisaer deleted the add_dedicated_columns_for_tikv_get branch September 12, 2019 07:33

aylei mentioned this pull request Sep 17, 2019

tkctl get tikv should show store-id and store state #564

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more columns for tkctl get tikv #842

Add more columns for tkctl get tikv #842

Yisaer commented Aug 29, 2019

CLAassistant commented Aug 29, 2019 •

edited

Loading

Yisaer commented Sep 4, 2019

gregwebs commented Sep 6, 2019

cofyc commented Sep 10, 2019

cofyc left a comment

Yisaer commented Sep 12, 2019

weekface left a comment

aylei left a comment

aylei commented Sep 12, 2019

Yisaer commented Sep 12, 2019

Yisaer commented Sep 12, 2019

cofyc commented Sep 12, 2019 •

edited

Loading

aylei left a comment

Yisaer commented Sep 12, 2019

Yisaer commented Sep 12, 2019

Add more columns for tkctl get tikv #842

Add more columns for tkctl get tikv #842

Conversation

Yisaer commented Aug 29, 2019

What problem does this PR solve?

What is changed and how does it work?

Check List

Does this PR introduce a user-facing change?:

CLAassistant commented Aug 29, 2019 • edited Loading

Yisaer commented Sep 4, 2019

gregwebs commented Sep 6, 2019

cofyc commented Sep 10, 2019

cofyc left a comment

Choose a reason for hiding this comment

Yisaer commented Sep 12, 2019

weekface left a comment

Choose a reason for hiding this comment

aylei left a comment

Choose a reason for hiding this comment

aylei commented Sep 12, 2019

Yisaer commented Sep 12, 2019

Yisaer commented Sep 12, 2019

cofyc commented Sep 12, 2019 • edited Loading

aylei left a comment

Choose a reason for hiding this comment

Yisaer commented Sep 12, 2019

Yisaer commented Sep 12, 2019

CLAassistant commented Aug 29, 2019 •

edited

Loading

cofyc commented Sep 12, 2019 •

edited

Loading