by default, don't give montior any cross-namespace access #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
force-pushed
the
monitor-no-cross-namespace
branch
from
cd82f20
to
a4ec6ee
Compare
weekface
approved these changes
Sep 16, 2019
|
/run-e2e-tests |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* Media: Improve 2 images involving third-party logos * Update tidb-operator-control-flow-1.1.png * Update tidb-operator-control-flow-1.1.png * update two images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #862. #854 enabled cross-namespace access in the tidb-cluster deployment.
What is changed and how does it work?
By default use the previous code. Add an option to use new code.
This maintains backwards compatibility with the previous chart.
Check List
Tests
I deployed both versions to a local kind cluster
Code changes
Related changes
Does this PR introduce a user-facing change?:
This maintains backwards compatibility. Most users won't need to change this setting.